Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1596333002: Revert of Oilpan: Fix weak processing for IntersectionObserver::m_root (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
haraken, szager1
CC:
chromium-reviews, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Oilpan: Fix weak processing for IntersectionObserver::m_root (patchset #3 id:40001 of https://codereview.chromium.org/1594813002/ ) Reason for revert: This and the parent change introduced some failures, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20Leak/builds/16410 backing out for now. Original issue's description: > Oilpan: Fix weak processing for IntersectionObserver::m_root > > This is a follow-up fix for https://codereview.chromium.org/1591763003/. > IntersectionObserver::m_root must be cleared in the weak callback when the m_root is dead. > > BUG= > > Committed: https://crrev.com/2760f06a3c43c8919f4ecae43f460ada20d0990b > Cr-Commit-Position: refs/heads/master@{#369956} TBR=szager@chromium.org,haraken@chromium.org BUG= NOTRY=true Committed: https://crrev.com/d802c7fd6a7c47f768885edc1f37a28bd13596ce Cr-Commit-Position: refs/heads/master@{#369969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +10 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
Created Revert of Oilpan: Fix weak processing for IntersectionObserver::m_root
4 years, 11 months ago (2016-01-17 21:25:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1596333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1596333002/1
4 years, 11 months ago (2016-01-17 21:25:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1596333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1596333002/1
4 years, 11 months ago (2016-01-17 21:32:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1596333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1596333002/1
4 years, 11 months ago (2016-01-17 21:35:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-17 21:36:12 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d802c7fd6a7c47f768885edc1f37a28bd13596ce Cr-Commit-Position: refs/heads/master@{#369969}
4 years, 11 months ago (2016-01-17 21:37:36 UTC) #11
haraken
4 years, 11 months ago (2016-01-18 03:20:27 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698