Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.h

Issue 1600243002: Revert of Use registerWeakMembers to clean up IntersectionObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/IntersectionObserver.h
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h
index a918acb4cab2f8f6a182a4fbfbeecd9ebbc6672f..f793a6f958543add45b3d8b5810b6d6c2297357d 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.h
+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.h
@@ -27,7 +27,6 @@
public:
static IntersectionObserver* create(const IntersectionObserverInit&, IntersectionObserverCallback&, ExceptionState&);
static void resumeSuspendedObservers();
- static void rootDisappearedCallback(Visitor*, void*);
// API methods
void observe(Element*, ExceptionState&);
@@ -57,6 +56,8 @@
private:
explicit IntersectionObserver(IntersectionObserverCallback&, Node&, const Vector<Length>& rootMargin, const Vector<float>& thresholds);
+ void checkRootAndDetachIfNeeded();
+
Member<IntersectionObserverCallback> m_callback;
WeakPtrWillBeWeakMember<Node> m_root;
HeapHashSet<WeakMember<IntersectionObservation>> m_observations;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698