Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1599803002: Subzero: Remove unneeded ScratchRegs. (Closed)

Created:
4 years, 11 months ago by Jim Stichnoth
Modified:
4 years, 11 months ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Remove unneeded ScratchRegs. These static members of the various TargetLowering classes are no longer used anywhere and can therefore be removed. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=29d15fd619f1d46f8e0c3d22932b9931c4b81367

Patch Set 1 #

Patch Set 2 : More cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -33 lines) Patch
M src/IceTargetLoweringARM32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLoweringARM32.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M src/IceTargetLoweringMIPS32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLoweringMIPS32.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/IceTargetLoweringX8632Traits.h View 1 5 chunks +2 lines, -6 lines 0 comments Download
M src/IceTargetLoweringX8664.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/IceTargetLoweringX8664Traits.h View 1 5 chunks +2 lines, -7 lines 0 comments Download
M src/IceTargetLoweringX86Base.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jim Stichnoth
4 years, 11 months ago (2016-01-16 18:50:05 UTC) #3
John
lgtm Can the columns in the .def file(s) be removed as well?
4 years, 11 months ago (2016-01-19 15:14:40 UTC) #4
Jim Stichnoth
On 2016/01/19 15:14:40, John wrote: > Can the columns in the .def file(s) be removed ...
4 years, 11 months ago (2016-01-19 17:55:58 UTC) #5
Jim Stichnoth
4 years, 11 months ago (2016-01-19 18:25:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
29d15fd619f1d46f8e0c3d22932b9931c4b81367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698