Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1599019: Change Math.random() to return 32 bits of random goodness, instead of 30 rand... (Closed)

Created:
10 years, 8 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry, Rico
CC:
v8-dev
Visibility:
Public.

Description

Change Math.random() to return 32 bits of random goodness, instead of 30 random bits. Math.random now allocates a HeapNumber inline, and calls a C funciton directly to put the random bits into it. Committed: http://code.google.com/p/v8/source/detail?r=4354

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -39 lines) Patch
M src/arm/codegen-arm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 1 1 chunk +16 lines, -2 lines 0 comments Download
M src/assembler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/codegen.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 1 chunk +20 lines, -6 lines 0 comments Download
M src/math.js View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/v8.cc View 1 1 chunk +20 lines, -7 lines 0 comments Download
M src/x64/codegen-x64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 1 1 chunk +29 lines, -7 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
William Hesse
Other JavaScript implementations return 32 random bits from Math.random. This changes makes us do the ...
10 years, 8 months ago (2010-04-06 14:51:39 UTC) #1
Erik Corry
ARM part LGTM
10 years, 8 months ago (2010-04-06 14:57:50 UTC) #2
Rico
LGTM Maybe we should also add it to the mips architecture as unimplemented (I am ...
10 years, 8 months ago (2010-04-07 07:36:32 UTC) #3
William Hesse
Also renamed the functions on the Mips platform. http://codereview.chromium.org/1599019/diff/1/15 File src/math.js (right): http://codereview.chromium.org/1599019/diff/1/15#newcode168 src/math.js:168: return ...
10 years, 8 months ago (2010-04-07 08:17:03 UTC) #4
William Hesse
10 years, 8 months ago (2010-04-07 08:18:13 UTC) #5
Also renamed the functions on the Mips platform.

Powered by Google App Engine
This is Rietveld 408576698