Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: src/x64/codegen-x64.cc

Issue 1599019: Change Math.random() to return 32 bits of random goodness, instead of 30 rand... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x64/codegen-x64.h ('k') | test/cctest/test-log-stack-tracer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/codegen-x64.cc
===================================================================
--- src/x64/codegen-x64.cc (revision 4353)
+++ src/x64/codegen-x64.cc (working copy)
@@ -4074,19 +4074,41 @@
}
-void CodeGenerator::GenerateRandomPositiveSmi(ZoneList<Expression*>* args) {
+void CodeGenerator::GenerateRandomHeapNumber(
+ ZoneList<Expression*>* args) {
ASSERT(args->length() == 0);
frame_->SpillAll();
- __ push(rsi);
- static const int num_arguments = 0;
- __ PrepareCallCFunction(num_arguments);
+ Label slow_allocate_heapnumber;
+ Label heapnumber_allocated;
+ __ AllocateHeapNumber(rdi, rbx, &slow_allocate_heapnumber);
+ __ jmp(&heapnumber_allocated);
- // Call V8::RandomPositiveSmi().
- __ CallCFunction(ExternalReference::random_positive_smi_function(),
- num_arguments);
+ __ bind(&slow_allocate_heapnumber);
+ // To allocate a heap number, and ensure that it is not a smi, we
+ // call the runtime function FUnaryMinus on 0, returning the double
+ // -0.0. A new, distinct heap number is returned each time.
+ __ Push(Smi::FromInt(0));
+ __ CallRuntime(Runtime::kNumberUnaryMinus, 1);
+ __ movq(rdi, rax);
+ __ bind(&heapnumber_allocated);
+
+ // Put a random number into the heap number rdi using a C++ function.
+ // Return the heap number in rax.
+#ifdef _WIN64
+ __ movq(rcx, rdi);
+#else
+ // Callee-save in Microsoft 64-bit ABI, but not in AMD64 ABI.
+ __ push(rsi);
+#endif
+ __ PrepareCallCFunction(1);
+ __ CallCFunction(ExternalReference::fill_heap_number_with_random_function(),
+ 1);
+#ifndef _WIN64
+ // Callee-save in Microsoft 64-bit ABI, but not in AMD64 ABI.
__ pop(rsi);
+#endif
Result result = allocator_->Allocate(rax);
frame_->Push(&result);
}
« no previous file with comments | « src/x64/codegen-x64.h ('k') | test/cctest/test-log-stack-tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698