Issue 159792: Make generators robust in the face of generator_flags being defined....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159792: Make generators robust in the face of generator_flags being defined.... (Closed)

Created:
11 years, 4 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/

Visibility:
Public.

Description

Make generators robust in the face of generator_flags being defined. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=571

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	trunk/pylib/gyp/generator/make.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/pylib/gyp/generator/msvs.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/pylib/gyp/generator/xcode.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

OK, LGTM. I suppose you needed this for the tests, because ordinary GYP always defines ...

11 years, 4 months ago (2009-08-03 16:52:44 UTC) #2

sgk1

11 years, 4 months ago (2009-08-03 17:04:14 UTC) #3

Actually, this came up on one of my experimental build slaves, which should
be normal gyp execution:
http://sgk.mtv.corp.google.com:8010/builders/Chromium%20Win%20Builds/builds/2...

Looks like something is perhaps out of date there?  Nevertheless, this seems
like reasonable belt-and-suspenders behavior.

        --SK

On Mon, Aug 3, 2009 at 9:52 AM, <mark@chromium.org> wrote:

> OK, LGTM.
>
> I suppose you needed this for the tests, because ordinary GYP always
> defines generator_flags.
>
>
> http://codereview.chromium.org/159792
>

Expand Messages | Collapse Messages