Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1808)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/pylib/gyp/generator/make.py

Issue 159792: Make generators robust in the face of generator_flags being defined.... (Closed) Base URL: http://gyp.googlecode.com/svn/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/pylib/gyp/generator/msvs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/pylib/gyp/generator/make.py
===================================================================
--- trunk/pylib/gyp/generator/make.py (revision 569)
+++ trunk/pylib/gyp/generator/make.py (working copy)
@@ -730,7 +730,7 @@
def GenerateOutput(target_list, target_dicts, data, params):
options = params['options']
- generator_flags = params['generator_flags']
+ generator_flags = params.get('generator_flags', {})
builddir_name = generator_flags.get('output_dir', 'out')
# TODO: search for the first non-'Default' target. This can go
« no previous file with comments | « no previous file | trunk/pylib/gyp/generator/msvs.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698