Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/pylib/gyp/generator/msvs.py

Issue 159792: Make generators robust in the face of generator_flags being defined.... (Closed) Base URL: http://gyp.googlecode.com/svn/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/pylib/gyp/generator/make.py ('k') | trunk/pylib/gyp/generator/xcode.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/pylib/gyp/generator/msvs.py
===================================================================
--- trunk/pylib/gyp/generator/msvs.py (revision 569)
+++ trunk/pylib/gyp/generator/msvs.py (working copy)
@@ -862,7 +862,7 @@
def CalculateVariables(default_variables, params):
"""Generated variables that require params to be known."""
- generator_flags = params['generator_flags']
+ generator_flags = params.get('generator_flags', {})
# Select project file format version (if unset, default to auto detecting).
msvs_version = \
@@ -896,7 +896,7 @@
"""
options = params['options']
- generator_flags = params['generator_flags']
+ generator_flags = params.get('generator_flags', {})
# Get the project file format version back out of where we stashed it in
# GeneratorCalculatedVariables.
« no previous file with comments | « trunk/pylib/gyp/generator/make.py ('k') | trunk/pylib/gyp/generator/xcode.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698