Refactor webkitpy.layout_tests.servers.server_base.

Refactor webkitpy.layout_tests.servers.server_base.

This moves some code from servers.lighttpd to server_base so that it can
be reused by the other server classes. This is a prelude to cleaning up
code in the other server classes.

R=scottmg@chromium.org
BUG=30536
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167051

[Dirk Pranke, 2014-02-11 22:09:25]

this patch depends on https://codereview.chromium.org/157123002/ , which should
be landing nowish ...

[scottmg, 2014-02-11 22:21:54]

lgtm

https://codereview.chromium.org/159723008/diff/1/Tools/Scripts/webkitpy/layou...
File Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py (right):

https://codereview.chromium.org/159723008/diff/1/Tools/Scripts/webkitpy/layou...
Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py:113: # FIXME: Doesn't
Executive have a devnull, so that we don't have to use os.devnull directly?
remove comment

[Dirk Pranke, 2014-02-12 21:03:40]

https://codereview.chromium.org/159723008/diff/1/Tools/Scripts/webkitpy/layou...
File Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py (right):

https://codereview.chromium.org/159723008/diff/1/Tools/Scripts/webkitpy/layou...
Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py:113: # FIXME: Doesn't
Executive have a devnull, so that we don't have to use os.devnull directly?
On 2014/02/11 22:21:54, scottmg wrote:
> remove comment

That gets removed in https://codereview.chromium.org/159713010 , so I'll leave
as-is for now.

[Dirk Pranke, 2014-02-12 21:03:50]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-02-12 21:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/159723008/1

[commit-bot: I haz the power, 2014-02-12 23:21:03]

Change committed as 167051