Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 159713010: Clean up the webkitpy.layout_tests.servers.pywebsocket implementation. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
blink-reviews, tyoshino (SeeGerritForStatus)
Visibility:
Public.

Description

Clean up the webkitpy.layout_tests.servers.pywebsocket implementation. This removes a lot of functionality that is no longer used or needed. R=scottmg@chromium.org BUG=30536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -139 lines) Patch
M Tools/Scripts/run-blink-websocketserver View 2 chunks +2 lines, -46 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py View 2 chunks +18 lines, -93 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
This patch depends on https://codereview.chromium.org/159723008/ having landed. Note that the websocket folks already approved this ...
6 years, 10 months ago (2014-02-11 22:22:08 UTC) #1
scottmg
lgtm
6 years, 10 months ago (2014-02-11 22:35:40 UTC) #2
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-14 00:08:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/159713010/1
6 years, 10 months ago (2014-02-14 00:09:25 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 02:07:58 UTC) #5
Message was sent while issue was closed.
Change committed as 167135

Powered by Google App Engine
This is Rietveld 408576698