Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py

Issue 159723008: Refactor webkitpy.layout_tests.servers.server_base. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py b/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
index 355ac03e13bf9b15bbd259426431ac5f9d1e8030..5908df130b541a118002d25052b1b46dae0e688a 100644
--- a/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
+++ b/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
@@ -47,15 +47,14 @@ class ApacheHTTP(server_base.ServerBase):
port_obj: handle to the platform-specific routines
output_dir: the absolute path to the layout test result directory
"""
- super(ApacheHTTP, self).__init__(port_obj, number_of_servers)
+ super(ApacheHTTP, self).__init__(port_obj, output_dir)
+ self._number_of_servers = number_of_servers
# We use the name "httpd" instead of "apache" to make our paths (e.g. the pid file: /tmp/WebKit/httpd.pid)
# match old-run-webkit-tests: https://bugs.webkit.org/show_bug.cgi?id=63956
self._name = 'httpd'
self._mappings = [{'port': 8000},
{'port': 8080},
{'port': 8443, 'sslcert': True}]
- self._output_dir = output_dir
- self._filesystem.maybe_make_directory(output_dir)
self._pid_file = self._filesystem.join(self._runtime_path, '%s.pid' % self._name)

Powered by Google App Engine
This is Rietveld 408576698