Add the new UMA key 'Translate.LocalesOnDisabledByPrefs'.

Add the new UMA key 'Translate.LocalesOnDisabledByPrefs'.

This logs the user locale when the Translate feature is disabled by the user. This allows us to investigate the correlation between the user locale and the usage rates of the Translate.

I'll commit this CL after https://chromiumcodereview.appspot.com/15311006/ is committed.

BUG=242142
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203113

[hajimehoshi, 2013-05-24 03:47:13]

Can you take a look at this CL?  Thank you.

[jar (doing other things), 2013-05-24 18:06:59]

Alexei: Can you comment on this CL?

https://codereview.chromium.org/15970002/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics.cc (right):

https://codereview.chromium.org/15970002/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.cc:60:
UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1);
Are you using this for a counter?

[Alexei Svitkine (slow), 2013-05-24 18:24:33]

https://codereview.chromium.org/15970002/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15970002/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:8622: Logs the user locale when the
Translate feature is disabled by the user.
Please mention when this is sampled.

From the current description, it sounds like this gets recorded when the user
actually disables translate, but from the code it looks like it may happen on
startup? Please clarify in the summary.

[hajimehoshi, 2013-05-27 01:13:26]

Thank you!

https://codereview.chromium.org/15970002/diff/1/chrome/browser/translate/tran...
File chrome/browser/translate/translate_manager_metrics.cc (right):

https://codereview.chromium.org/15970002/diff/1/chrome/browser/translate/tran...
chrome/browser/translate/translate_manager_metrics.cc:60:
UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1);
This will be fixed by https://chromiumcodereview.appspot.com/15311006/.  I'll
commit this CL after 15311006 is committed.

On 2013/05/24 18:06:59, jar wrote:
> Are you using this for a counter?

https://codereview.chromium.org/15970002/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15970002/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:8622: Logs the user locale when the
Translate feature is disabled by the user.
TranslateManager::InitiateTranslation is called each time a webpage is loaded.

On 2013/05/24 18:24:33, Alexei Svitkine wrote:
> Please mention when this is sampled.
> 
> From the current description, it sounds like this gets recorded when the user
> actually disables translate, but from the code it looks like it may happen on
> startup? Please clarify in the summary.

[Takashi Toyoshima, 2013-05-27 07:39:03]

lgtm on translate/

https://codereview.chromium.org/15970002/diff/10001/chrome/browser/translate/...
File chrome/browser/translate/translate_manager_metrics_unittest.cc (right):

https://codereview.chromium.org/15970002/diff/10001/chrome/browser/translate/...
chrome/browser/translate/translate_manager_metrics_unittest.cc:91:
HistogramBase::Count GetCountInternal(HistogramBase::Sample value) {
[optional] this function name is vague. can you rename to
GetCountWithoutSnapshot() or something?

[hajimehoshi, 2013-05-27 08:24:21]

Thanks!

https://codereview.chromium.org/15970002/diff/10001/chrome/browser/translate/...
File chrome/browser/translate/translate_manager_metrics_unittest.cc (right):

https://codereview.chromium.org/15970002/diff/10001/chrome/browser/translate/...
chrome/browser/translate/translate_manager_metrics_unittest.cc:91:
HistogramBase::Count GetCountInternal(HistogramBase::Sample value) {
Ok, I'll rename this at
https://chromiumcodereview.appspot.com/15311006/patch/45002/62007 because
15311006 will be committed ahead of this CL.

On 2013/05/27 07:39:03, Takashi Toyoshima (chromium) wrote:
> [optional] this function name is vague. can you rename to
> GetCountWithoutSnapshot() or something?

[Alexei Svitkine (slow), 2013-05-27 15:30:24]

histograms.xml change lgtm

[jar (doing other things), 2013-05-27 16:52:50]

As per Alexei... histograms.xml LGTM

[commit-bot: I haz the power, 2013-05-30 02:22:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/15970002/18001

[commit-bot: I haz the power, 2013-05-30 08:07:59]

Change committed as 203113