Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: chrome/browser/translate/translate_manager_metrics.cc

Issue 15970002: Add the new UMA key 'Translate.LocalesOnDisabledByPrefs'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_manager_metrics.h" 5 #include "chrome/browser/translate/translate_manager_metrics.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/metrics/sparse_histogram.h"
10 #include "chrome/browser/language_usage_metrics.h"
9 11
10 namespace { 12 namespace {
11 13
12 // Constant string values to indicate UMA names. All entries should have 14 // Constant string values to indicate UMA names. All entries should have
13 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|. 15 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|.
14 const char kTranslateInitiationStatus[] = 16 const char kTranslateInitiationStatus[] =
15 "Translate.InitiationStatus"; 17 "Translate.InitiationStatus";
16 const char kTranslateReportLanguageDetectionError[] = 18 const char kTranslateReportLanguageDetectionError[] =
17 "Translate.ReportLanguageDetectionError"; 19 "Translate.ReportLanguageDetectionError";
18 const char kTranslateServerReportedUnsupportedLanguage[] = 20 const char kTranslateServerReportedUnsupportedLanguage[] =
19 "Translate.ServerReportedUnsupportedLanguage"; 21 "Translate.ServerReportedUnsupportedLanguage";
22 const char kTranslateLocalesOnDisabledByPrefs[] =
23 "Translate.LocalesOnDisabledByPrefs";
20 24
21 struct MetricsEntry { 25 struct MetricsEntry {
22 TranslateManagerMetrics::MetricsNameIndex index; 26 TranslateManagerMetrics::MetricsNameIndex index;
23 const char* const name; 27 const char* const name;
24 }; 28 };
25 29
26 // This entry table should be updated when new UMA items are added. 30 // This entry table should be updated when new UMA items are added.
27 const MetricsEntry kMetricsEntries[] = { 31 const MetricsEntry kMetricsEntries[] = {
28 { TranslateManagerMetrics::UMA_INITIATION_STATUS, 32 { TranslateManagerMetrics::UMA_INITIATION_STATUS,
29 kTranslateInitiationStatus }, 33 kTranslateInitiationStatus },
30 { TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR, 34 { TranslateManagerMetrics::UMA_LANGUAGE_DETECTION_ERROR,
31 kTranslateReportLanguageDetectionError }, 35 kTranslateReportLanguageDetectionError },
32 { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE, 36 { TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE,
33 kTranslateServerReportedUnsupportedLanguage }, 37 kTranslateServerReportedUnsupportedLanguage },
38 { TranslateManagerMetrics::UMA_LOCALES_ON_DISABLED_BY_PREFS,
39 kTranslateLocalesOnDisabledByPrefs },
34 }; 40 };
35 41
36 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX, 42 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateManagerMetrics::UMA_MAX,
37 arraysize_of_kMetricsEntries_should_be_UMA_MAX); 43 arraysize_of_kMetricsEntries_should_be_UMA_MAX);
38 44
39 } // namespace 45 } // namespace
40 46
41 namespace TranslateManagerMetrics { 47 namespace TranslateManagerMetrics {
42 48
43 void ReportInitiationStatus(InitiationStatusType type) { 49 void ReportInitiationStatus(InitiationStatusType type) {
44 UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus, 50 UMA_HISTOGRAM_ENUMERATION(kTranslateInitiationStatus,
45 type, 51 type,
46 INITIATION_STATUS_MAX); 52 INITIATION_STATUS_MAX);
47 } 53 }
48 54
49 void ReportLanguageDetectionError() { 55 void ReportLanguageDetectionError() {
50 UMA_HISTOGRAM_COUNTS(kTranslateReportLanguageDetectionError, 1); 56 UMA_HISTOGRAM_COUNTS(kTranslateReportLanguageDetectionError, 1);
51 } 57 }
52 58
53 void ReportUnsupportedLanguage() { 59 void ReportUnsupportedLanguage() {
54 UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1); 60 UMA_HISTOGRAM_COUNTS(kTranslateServerReportedUnsupportedLanguage, 1);
jar (doing other things) 2013/05/24 18:06:59 Are you using this for a counter?
hajimehoshi 2013/05/27 01:13:26 This will be fixed by https://chromiumcodereview.a
55 } 61 }
56 62
63 void ReportLocalesOnDisabledByPrefs(const std::string& locale) {
64 UMA_HISTOGRAM_SPARSE_SLOWLY(kTranslateLocalesOnDisabledByPrefs,
65 LanguageUsageMetrics::ToLanguageCode(locale));
66 }
67
57 const char* GetMetricsName(MetricsNameIndex index) { 68 const char* GetMetricsName(MetricsNameIndex index) {
58 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) { 69 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
59 if (kMetricsEntries[i].index == index) 70 if (kMetricsEntries[i].index == index)
60 return kMetricsEntries[i].name; 71 return kMetricsEntries[i].name;
61 } 72 }
62 NOTREACHED(); 73 NOTREACHED();
63 return NULL; 74 return NULL;
64 } 75 }
65 76
66 } // namespace TranslateManagerMetrics 77 } // namespace TranslateManagerMetrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698