Add the new UMA key 'Translate.LocalesOnDisabledByPrefs'.

chrome/browser/translate/translate_manager_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_manager_metrics.h"
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/histogram_samples.h"
@@ skipping 25 matching lines @@
                              int expected_disabled_by_config,
                              int expected_language_is_not_supported,
                              int expected_url_is_not_supported,
                              int expected_similar_languages,
                              int expected_accept_languages,
                              int expected_auto_by_config,
                              int expected_auto_by_link,
                              int expected_show_infobar) {
     Snapshot();
 
-    EXPECT_EQ(expected_disabled_by_prefs, GetCount(
+    EXPECT_EQ(expected_disabled_by_prefs, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_DISABLED_BY_PREFS));
-    EXPECT_EQ(expected_disabled_by_switch, GetCount(
+    EXPECT_EQ(expected_disabled_by_switch, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_DISABLED_BY_SWITCH));
-    EXPECT_EQ(expected_disabled_by_config, GetCount(
+    EXPECT_EQ(expected_disabled_by_config, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_DISABLED_BY_CONFIG));
-    EXPECT_EQ(expected_language_is_not_supported, GetCount(
+    EXPECT_EQ(expected_language_is_not_supported, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_LANGUAGE_IS_NOT_SUPPORTED));
-    EXPECT_EQ(expected_url_is_not_supported, GetCount(
+    EXPECT_EQ(expected_url_is_not_supported, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_URL_IS_NOT_SUPPORTED));
-    EXPECT_EQ(expected_similar_languages, GetCount(
+    EXPECT_EQ(expected_similar_languages, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_SIMILAR_LANGUAGES));
-    EXPECT_EQ(expected_accept_languages, GetCount(
+    EXPECT_EQ(expected_accept_languages, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_ACCEPT_LANGUAGES));
-    EXPECT_EQ(expected_auto_by_config, GetCount(
+    EXPECT_EQ(expected_auto_by_config, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_AUTO_BY_CONFIG));
-    EXPECT_EQ(expected_auto_by_link, GetCount(
+    EXPECT_EQ(expected_auto_by_link, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_AUTO_BY_LINK));
-    EXPECT_EQ(expected_show_infobar, GetCount(
+    EXPECT_EQ(expected_show_infobar, GetCountInternal(
         TranslateManagerMetrics::INITIATION_STATUS_SHOW_INFOBAR));
   }
 
   HistogramBase::Count GetTotalCount() {
     Snapshot();
     if (!samples_.get())
       return 0;
     HistogramBase::Count count = samples_->TotalCount();
     if (!base_samples_.get())
       return count;
     return count - base_samples_->TotalCount();
   }
 
+  HistogramBase::Count GetCount(HistogramBase::Sample value) {
+    Snapshot();
+    return GetCountInternal(value);
+  }
+
  private:
   void Snapshot() {
     HistogramBase* histogram = StatisticsRecorder::FindHistogram(key_);
     if (!histogram)
       return;
     samples_ = histogram->SnapshotSamples();
   }
 
-  HistogramBase::Count GetCount(HistogramBase::Sample value) {
+  HistogramBase::Count GetCountInternal(HistogramBase::Sample value) {

[Takashi Toyoshima, 2013/05/27 07:39:03]

[optional] this function name is vague. can you rename to
GetCountWithoutSnapshot() or something?

[hajimehoshi, 2013/05/27 08:24:21]

Ok, I'll rename this at
https://chromiumcodereview.appspot.com/15311006/patch/45002/62007 because
15311006 will be committed ahead of this CL.

On 2013/05/27 07:39:03, Takashi Toyoshima (chromium) wrote:

     if (!samples_.get())
       return 0;
     HistogramBase::Count count = samples_->GetCount(value);
     if (!base_samples_.get())
       return count;
     return count - base_samples_->GetCount(value);
   }
 
   std::string key_;
   scoped_ptr<HistogramSamples> base_samples_;
@@ skipping 49 matching lines @@
   EXPECT_EQ(1, recorder.GetTotalCount());
 }
 
 TEST(TranslateManagerMetricsTest, ReportedUnsupportedLanguage) {
   MetricsRecorder recorder(TranslateManagerMetrics::GetMetricsName(
       TranslateManagerMetrics::UMA_SERVER_REPORTED_UNSUPPORTED_LANGUAGE));
   EXPECT_EQ(0, recorder.GetTotalCount());
   TranslateManagerMetrics::ReportUnsupportedLanguage();
   EXPECT_EQ(1, recorder.GetTotalCount());
 }
+
+TEST(TranslateManagerMetricsTest, ReportedLocalesOnDisabledByPrefs) {
+  const int ENGLISH = 25966;
+
+  MetricsRecorder recorder(TranslateManagerMetrics::GetMetricsName(
+      TranslateManagerMetrics::UMA_LOCALES_ON_DISABLED_BY_PREFS));
+  EXPECT_EQ(0, recorder.GetTotalCount());
+  TranslateManagerMetrics::ReportLocalesOnDisabledByPrefs("en");
+  EXPECT_EQ(1, recorder.GetCount(ENGLISH));
+}