Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1596293003: Use default argument count for runtime function calls. (Closed)

Created:
4 years, 11 months ago by Camillo Bruni
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use default argument count for runtime function calls. In many places we over-specify runtime-calls by explicitly mentioning again the argument count. Except for var-args runtime-functions we can easily deduce this from the parameters in runtime.h. BUG= Committed: https://crrev.com/5346972186322aa80a01b8700fff254b9aeb0234 Cr-Commit-Position: refs/heads/master@{#33363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -69 lines) Patch
M src/arm/macro-assembler-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 27 chunks +27 lines, -34 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1596293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1596293003/1
4 years, 11 months ago (2016-01-18 09:57:33 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-18 10:19:31 UTC) #4
Camillo Bruni
Hi Benedikt, PTAL at this refactoring. thanks.
4 years, 11 months ago (2016-01-18 12:57:49 UTC) #7
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-18 14:00:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1596293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1596293003/1
4 years, 11 months ago (2016-01-18 14:46:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 14:48:16 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 14:48:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5346972186322aa80a01b8700fff254b9aeb0234
Cr-Commit-Position: refs/heads/master@{#33363}

Powered by Google App Engine
This is Rietveld 408576698