Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 1596293003: Use default argument count for runtime function calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ppc/macro-assembler-ppc.cc ('k') | src/x87/macro-assembler-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/division-by-constant.h" 8 #include "src/base/division-by-constant.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 #endif 582 #endif
583 583
584 Move(kScratchRegister, Smi::FromInt(static_cast<int>(reason)), 584 Move(kScratchRegister, Smi::FromInt(static_cast<int>(reason)),
585 Assembler::RelocInfoNone()); 585 Assembler::RelocInfoNone());
586 Push(kScratchRegister); 586 Push(kScratchRegister);
587 587
588 if (!has_frame_) { 588 if (!has_frame_) {
589 // We don't actually want to generate a pile of code for this, so just 589 // We don't actually want to generate a pile of code for this, so just
590 // claim there is a stack frame, without generating one. 590 // claim there is a stack frame, without generating one.
591 FrameScope scope(this, StackFrame::NONE); 591 FrameScope scope(this, StackFrame::NONE);
592 CallRuntime(Runtime::kAbort, 1); 592 CallRuntime(Runtime::kAbort);
593 } else { 593 } else {
594 CallRuntime(Runtime::kAbort, 1); 594 CallRuntime(Runtime::kAbort);
595 } 595 }
596 // Control will not return here. 596 // Control will not return here.
597 int3(); 597 int3();
598 } 598 }
599 599
600 600
601 void MacroAssembler::CallStub(CodeStub* stub, TypeFeedbackId ast_id) { 601 void MacroAssembler::CallStub(CodeStub* stub, TypeFeedbackId ast_id) {
602 DCHECK(AllowThisStubCall(stub)); // Calls are not allowed in some stubs 602 DCHECK(AllowThisStubCall(stub)); // Calls are not allowed in some stubs
603 Call(stub->GetCode(), RelocInfo::CODE_TARGET, ast_id); 603 Call(stub->GetCode(), RelocInfo::CODE_TARGET, ast_id);
604 } 604 }
(...skipping 3600 matching lines...) Expand 10 before | Expand all | Expand 10 after
4205 } 4205 }
4206 if (actual.is_reg()) { 4206 if (actual.is_reg()) {
4207 Integer32ToSmi(actual.reg(), actual.reg()); 4207 Integer32ToSmi(actual.reg(), actual.reg());
4208 Push(actual.reg()); 4208 Push(actual.reg());
4209 } 4209 }
4210 if (new_target.is_valid()) { 4210 if (new_target.is_valid()) {
4211 Push(new_target); 4211 Push(new_target);
4212 } 4212 }
4213 Push(fun); 4213 Push(fun);
4214 Push(fun); 4214 Push(fun);
4215 CallRuntime(Runtime::kDebugPrepareStepInIfStepping, 1); 4215 CallRuntime(Runtime::kDebugPrepareStepInIfStepping);
4216 Pop(fun); 4216 Pop(fun);
4217 if (new_target.is_valid()) { 4217 if (new_target.is_valid()) {
4218 Pop(new_target); 4218 Pop(new_target);
4219 } 4219 }
4220 if (actual.is_reg()) { 4220 if (actual.is_reg()) {
4221 Pop(actual.reg()); 4221 Pop(actual.reg());
4222 SmiToInteger64(actual.reg(), actual.reg()); 4222 SmiToInteger64(actual.reg(), actual.reg());
4223 } 4223 }
4224 if (expected.is_reg()) { 4224 if (expected.is_reg()) {
4225 Pop(expected.reg()); 4225 Pop(expected.reg());
(...skipping 1296 matching lines...) Expand 10 before | Expand all | Expand 10 after
5522 movl(rax, dividend); 5522 movl(rax, dividend);
5523 shrl(rax, Immediate(31)); 5523 shrl(rax, Immediate(31));
5524 addl(rdx, rax); 5524 addl(rdx, rax);
5525 } 5525 }
5526 5526
5527 5527
5528 } // namespace internal 5528 } // namespace internal
5529 } // namespace v8 5529 } // namespace v8
5530 5530
5531 #endif // V8_TARGET_ARCH_X64 5531 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ppc/macro-assembler-ppc.cc ('k') | src/x87/macro-assembler-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698