Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: src/arm64/macro-assembler-arm64.cc

Issue 1596293003: Use default argument count for runtime function calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/division-by-constant.h" 8 #include "src/base/division-by-constant.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2405 matching lines...) Expand 10 before | Expand all | Expand 10 after
2416 } 2416 }
2417 if (actual.is_reg()) { 2417 if (actual.is_reg()) {
2418 SmiTag(actual.reg()); 2418 SmiTag(actual.reg());
2419 Push(actual.reg()); 2419 Push(actual.reg());
2420 } 2420 }
2421 if (new_target.is_valid()) { 2421 if (new_target.is_valid()) {
2422 Push(new_target); 2422 Push(new_target);
2423 } 2423 }
2424 Push(fun); 2424 Push(fun);
2425 Push(fun); 2425 Push(fun);
2426 CallRuntime(Runtime::kDebugPrepareStepInIfStepping, 1); 2426 CallRuntime(Runtime::kDebugPrepareStepInIfStepping);
2427 Pop(fun); 2427 Pop(fun);
2428 if (new_target.is_valid()) { 2428 if (new_target.is_valid()) {
2429 Pop(new_target); 2429 Pop(new_target);
2430 } 2430 }
2431 if (actual.is_reg()) { 2431 if (actual.is_reg()) {
2432 Pop(actual.reg()); 2432 Pop(actual.reg());
2433 SmiUntag(actual.reg()); 2433 SmiUntag(actual.reg());
2434 } 2434 }
2435 if (expected.is_reg()) { 2435 if (expected.is_reg()) {
2436 Pop(expected.reg()); 2436 Pop(expected.reg());
(...skipping 1965 matching lines...) Expand 10 before | Expand all | Expand 10 after
4402 // Avoid infinite recursion; Push contains some assertions that use Abort. 4402 // Avoid infinite recursion; Push contains some assertions that use Abort.
4403 NoUseRealAbortsScope no_real_aborts(this); 4403 NoUseRealAbortsScope no_real_aborts(this);
4404 4404
4405 Mov(x0, Smi::FromInt(reason)); 4405 Mov(x0, Smi::FromInt(reason));
4406 Push(x0); 4406 Push(x0);
4407 4407
4408 if (!has_frame_) { 4408 if (!has_frame_) {
4409 // We don't actually want to generate a pile of code for this, so just 4409 // We don't actually want to generate a pile of code for this, so just
4410 // claim there is a stack frame, without generating one. 4410 // claim there is a stack frame, without generating one.
4411 FrameScope scope(this, StackFrame::NONE); 4411 FrameScope scope(this, StackFrame::NONE);
4412 CallRuntime(Runtime::kAbort, 1); 4412 CallRuntime(Runtime::kAbort);
4413 } else { 4413 } else {
4414 CallRuntime(Runtime::kAbort, 1); 4414 CallRuntime(Runtime::kAbort);
4415 } 4415 }
4416 } else { 4416 } else {
4417 // Load the string to pass to Printf. 4417 // Load the string to pass to Printf.
4418 Label msg_address; 4418 Label msg_address;
4419 Adr(x0, &msg_address); 4419 Adr(x0, &msg_address);
4420 4420
4421 // Call Printf directly to report the error. 4421 // Call Printf directly to report the error.
4422 CallPrintf(); 4422 CallPrintf();
4423 4423
4424 // We need a way to stop execution on both the simulator and real hardware, 4424 // We need a way to stop execution on both the simulator and real hardware,
(...skipping 475 matching lines...) Expand 10 before | Expand all | Expand 10 after
4900 } 4900 }
4901 4901
4902 4902
4903 #undef __ 4903 #undef __
4904 4904
4905 4905
4906 } // namespace internal 4906 } // namespace internal
4907 } // namespace v8 4907 } // namespace v8
4908 4908
4909 #endif // V8_TARGET_ARCH_ARM64 4909 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698