Issue 15954007: Revert 202478 "Revert 202388 "Remove NetworkStateInformer's depe..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15954007: Revert 202478 "Revert 202388 "Remove NetworkStateInformer's depe..." (Closed)

Created:
7 years, 7 months ago by kinuko

Modified:
7 years, 7 months ago

Reviewers:
kinuko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 202478 "Revert 202388 "Remove NetworkStateInformer's depe..." Reverting the speculative revert > Revert 202388 "Remove NetworkStateInformer's dependency on Proxy..." > > Suspected to break CrOS ASAN (x86) bot. > > > Remove NetworkStateInformer's dependency on ProxyConfigServiceImpl. > > > > This also completes NetworkStateInformer's migration from NetworkLibrary to > > NetworkStateHandler > > > > BUG=189009 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201688 > > > > R=stevenjb@chromium.org, ygorshenin@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202192 > > > > Review URL: https://codereview.chromium.org/15294010 > > TBR=pneubeck@chromium.org > > Review URL: https://codereview.chromium.org/15875018 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202503

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -50 lines)			Patch
M	trunk/src/chrome/browser/ui/webui/chromeos/login/network_state_informer.h	View	3 chunks	+2 lines, -17 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc	View	4 chunks	+8 lines, -16 lines	0 comments	Download
M	trunk/src/chromeos/network/managed_state.h	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	trunk/src/chromeos/network/network_state.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	trunk/src/chromeos/network/network_state.cc	View	6 chunks	+32 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r202503.