Remove NetworkStateInformer's dependency on ProxyConfigServiceImpl.

Remove NetworkStateInformer's dependency on ProxyConfigServiceImpl.

This also completes NetworkStateInformer's migration from NetworkLibrary to
NetworkStateHandler

BUG=189009
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201688

R=stevenjb@chromium.org, ygorshenin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202192

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202388

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203406

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203696

[pneubeck (no reviews), 2013-05-17 15:53:25]

Hi Yuri,
please review this CL instead of the larger
https://codereview.chromium.org/14846004/
which I splitted for better reviewability.

Thanks.

PS: I know that the test are not all running, working on that.

[pneubeck (no reviews), 2013-05-17 17:37:02]

@Steven, PTAL. This is another part separated form the larger CL.
It adds ProxyConfig but not OncSource to the NetworkState.

[ygorshenin1, 2013-05-20 06:03:07]

lgtm

[stevenjb, 2013-05-20 15:42:17]

https://codereview.chromium.org/15294010/diff/3001/chromeos/network/network_s...
File chromeos/network/network_state.cc (right):

https://codereview.chromium.org/15294010/diff/3001/chromeos/network/network_s...
chromeos/network/network_state.cc:120:
proxy_config_.MergeDictionary(proxy_config_dict.get());
Is the merge necessary here, especially given that this is temporary?
NetworkState should only reflect / cache Shill state; it shouldn't hold any
state of it's own. I don't see any local setter for proxy_config_, so the merge
should be unnecessary.

[pneubeck (no reviews), 2013-05-21 09:17:44]

https://codereview.chromium.org/15294010/diff/3001/chromeos/network/network_s...
File chromeos/network/network_state.cc (right):

https://codereview.chromium.org/15294010/diff/3001/chromeos/network/network_s...
chromeos/network/network_state.cc:120:
proxy_config_.MergeDictionary(proxy_config_dict.get());
On 2013/05/20 15:42:17, stevenjb (chromium) wrote:
> Is the merge necessary here, especially given that this is temporary?
> NetworkState should only reflect / cache Shill state; it shouldn't hold any
> state of it's own. I don't see any local setter for proxy_config_, so the
merge
> should be unnecessary.

Replaced by swap.

[stevenjb, 2013-05-21 15:40:00]

lgtm

https://codereview.chromium.org/15294010/diff/15002/chromeos/network/managed_...
File chromeos/network/managed_state.h (right):

https://codereview.chromium.org/15294010/diff/15002/chromeos/network/managed_...
chromeos/network/managed_state.h:50: // If the return value is true, the state
might or might not be notified.
s/notified/modified

[pneubeck (no reviews), 2013-05-22 07:35:14]

https://codereview.chromium.org/15294010/diff/15002/chromeos/network/managed_...
File chromeos/network/managed_state.h (right):

https://codereview.chromium.org/15294010/diff/15002/chromeos/network/managed_...
chromeos/network/managed_state.h:50: // If the return value is true, the state
might or might not be notified.
On 2013/05/21 15:40:00, stevenjb (chromium) wrote:
> s/notified/modified

Done.

[commit-bot: I haz the power, 2013-05-22 07:35:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/15294010/30001

[commit-bot: I haz the power, 2013-05-22 10:13:22]

Retried try job too often on win7_aura for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-22 10:35:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/15294010/30001

[commit-bot: I haz the power, 2013-05-22 18:03:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/15294010/48001

[commit-bot: I haz the power, 2013-05-23 04:31:52]

Change committed as 201688

[pneubeck (no reviews), 2013-05-24 09:17:01]

@Bartosz, could you take a look at the small fix so that I can retry the commit?
Thanks.

[commit-bot: I haz the power, 2013-05-24 16:46:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/15294010/77001

[pneubeck (no reviews), 2013-05-24 22:10:58]

Committed patchset #10 manually as r202192 (presubmit successful).

[pneubeck (no reviews), 2013-05-27 08:44:48]

Committed patchset #10 manually as r202388 (presubmit successful).

[pneubeck (no reviews), 2013-05-31 15:16:06]

Committed patchset #11 manually as r203406 (presubmit successful).

[pneubeck (no reviews), 2013-06-03 11:14:08]

Committed patchset #12 manually as r203696 (presubmit successful).