Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 15875018: Revert 202388 "Remove NetworkStateInformer's dependency on Proxy..." (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202388 "Remove NetworkStateInformer's dependency on Proxy..." Suspected to break CrOS ASAN (x86) bot. > Remove NetworkStateInformer's dependency on ProxyConfigServiceImpl. > > This also completes NetworkStateInformer's migration from NetworkLibrary to > NetworkStateHandler > > BUG=189009 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201688 > > R=stevenjb@chromium.org, ygorshenin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202192 > > Review URL: https://codereview.chromium.org/15294010 TBR=pneubeck@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -55 lines) Patch
M trunk/src/chrome/browser/ui/webui/chromeos/login/network_state_informer.h View 3 chunks +17 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/network_state_informer.cc View 4 chunks +16 lines, -8 lines 0 comments Download
M trunk/src/chromeos/network/managed_state.h View 1 chunk +3 lines, -8 lines 0 comments Download
M trunk/src/chromeos/network/network_state.h View 3 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/chromeos/network/network_state.cc View 6 chunks +8 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
7 years, 7 months ago (2013-05-28 01:54:02 UTC) #1
kinuko
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20%28x86%29%20ASAN/builds/4620 It's speculative, will revert the revert if this doesn't fix.
7 years, 7 months ago (2013-05-28 01:55:26 UTC) #2
kinuko
Committed patchset #1 manually as r202478.
7 years, 7 months ago (2013-05-28 01:55:36 UTC) #3
kinuko
Hmm... it's cycled green before this revert lands (though there has been flakiness). I'll revert ...
7 years, 7 months ago (2013-05-28 03:33:08 UTC) #4
kinuko
Ok, after the first revert the CrOS (x86) ASAN succeeded 3 times in a row, ...
7 years, 7 months ago (2013-05-28 07:36:40 UTC) #5
kinuko
7 years, 7 months ago (2013-05-28 07:38:30 UTC) #6
Message was sent while issue was closed.
On 2013/05/28 07:36:40, kinuko wrote:
> Ok, after the first revert the CrOS (x86) ASAN succeeded 3 times in a row, and
> after reverting the revert it started failing again.
> 
> So I assume my first revert was probably right.  Will be reverting this
again...
> sorry!

Additional logs:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Chromium%20OS...

Powered by Google App Engine
This is Rietveld 408576698