Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 47a0666e3fc7ad50225110e7f394da8adf08c83c..52d2726c809f0c0424761b18cdcef21ccc57c80a 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -948,11 +948,11 @@ void URLRequestHttpJob::OnStartCompleted(int result) {
scoped_refptr<HttpResponseHeaders> headers = GetResponseHeaders();
if (headers) {
- void* iter = NULL;
+ size_t iter = 0;
std::string name;
std::string value;
bool invalid_header_values_in_rfc7230 = false;
- while (headers->EnumerateHeaderLines(&iter, &name, &value)) {
+ while (headers->EnumerateHeaderLines(iter, &name, &value)) {
if (!HttpUtil::IsValidHeaderValueRFC7230(value)) {
invalid_header_values_in_rfc7230 = true;
break;

Powered by Google App Engine
This is Rietveld 408576698