Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

net/http/http_response_headers.h

Index: net/http/http_response_headers.h
diff --git a/net/http/http_response_headers.h b/net/http/http_response_headers.h
index 91c223ebe8153a0a811af7cee9b93a87fe489010..d623c57f321afb6c17043cd2f05c11fc2a43ac72 100644
--- a/net/http/http_response_headers.h
+++ b/net/http/http_response_headers.h
@@ -163,10 +163,10 @@ class NET_EXPORT HttpResponseHeaders
   // header appears on multiple lines, then it will appear multiple times in
   // this enumeration (in the order the header lines were received from the
   // server).  Also, a given header might have an empty value.  Initialize a
-  // 'void*' variable to NULL and pass it by address to EnumerateHeaderLines.
+  // 'size_t' variable to 0 and pass it by address to EnumerateHeaderLines.
   // Call EnumerateHeaderLines repeatedly until it returns false.  The
   // out-params 'name' and 'value' are set upon success.
-  bool EnumerateHeaderLines(void** iter,
+  bool EnumerateHeaderLines(size_t& i,

[mmenke, 2016/01/19 22:32:24]

Also, "i" isn't meaningful name.  Maybe just "index", though that may expose too
much to consumers, and encourage incorrect usage.  Could just stick with iter.

[mmenke, 2016/01/19 22:32:24]

Passing by non-const reference is forbidden.  Use size_t*.

                             std::string* name,
                             std::string* value) const;