Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index 59951ae8f7bcf744c789d6b5cb3d3b67a8f57bdd..8585c08e3fa67b772d879a8b6272176e6743c20c 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -3067,10 +3067,10 @@ TEST_P(SpdyNetworkTransactionTest, SynReplyHeaders) {
scoped_refptr<HttpResponseHeaders> headers = out.response_info.headers;
EXPECT_TRUE(headers.get() != NULL);
- void* iter = NULL;
+ size_t iter = 0;
std::string name, value;
SpdyHeaderBlock header_block;
- while (headers->EnumerateHeaderLines(&iter, &name, &value)) {
+ while (headers->EnumerateHeaderLines(iter, &name, &value)) {
SpdyHeaderBlock::StringPieceProxy mutable_header_block_value =
header_block[name];
if (static_cast<StringPiece>(mutable_header_block_value).empty()) {
@@ -3180,9 +3180,9 @@ TEST_P(SpdyNetworkTransactionTest, SynReplyHeadersVary) {
// Check the headers.
scoped_refptr<HttpResponseHeaders> headers = out.response_info.headers;
ASSERT_TRUE(headers.get() != NULL) << i;
- void* iter = NULL;
+ size_t iter = 0;
std::string name, value, lines;
- while (headers->EnumerateHeaderLines(&iter, &name, &value)) {
+ while (headers->EnumerateHeaderLines(iter, &name, &value)) {
lines.append(name);
lines.append(": ");
lines.append(value);

Powered by Google App Engine
This is Rietveld 408576698