ios/net/protocol_handler_util.mm - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/net/protocol_handler_util.mm

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/web_request_event_details.cc ('k') | ios/web/public/test/response_providers/data_response_provider.mm » ('j') | net/http/http_response_headers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/net/protocol_handler_util.mm

diff --git a/ios/net/protocol_handler_util.mm b/ios/net/protocol_handler_util.mm

index d1878c54bbc3dc66ba324ed4335198c784b44b5d..7bdafd30765f6c86a46de5afef51acc06d5c12b4 100644

--- a/ios/net/protocol_handler_util.mm

+++ b/ios/net/protocol_handler_util.mm

@@ -90,9 +90,9 @@ NSURLResponse* GetNSURLResponseForRequest(URLRequest* request) {

NSMutableDictionary* header_fields = [NSMutableDictionary dictionary];

HttpResponseHeaders* headers = request->response_headers();

if (headers != nullptr) {

- void* iter = nullptr;

+ size_t iter = 0;

std::string name, value;

- while (headers->EnumerateHeaderLines(&iter, &name, &value)) {

+ while (headers->EnumerateHeaderLines(iter, &name, &value)) {

NSString* key = base::SysUTF8ToNSString(name);

if (!key) {

DLOG(ERROR) << "Header name is not in UTF8: " << name;