Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: extensions/browser/api/web_request/web_request_event_details.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_event_details.cc
diff --git a/extensions/browser/api/web_request/web_request_event_details.cc b/extensions/browser/api/web_request/web_request_event_details.cc
index 958faea1a50c7688e911fb7771d73d27c6f5af4d..5900388c8dcc816a1536cd2608a322e26f3db0d7 100644
--- a/extensions/browser/api/web_request/web_request_event_details.cc
+++ b/extensions/browser/api/web_request/web_request_event_details.cc
@@ -133,10 +133,10 @@ void WebRequestEventDetails::SetResponseHeaders(
if (extra_info_spec_ & ExtraInfoSpec::RESPONSE_HEADERS) {
base::ListValue* headers = new base::ListValue();
if (response_headers) {
- void* iter = nullptr;
+ size_t iter = 0;
std::string name;
std::string value;
- while (response_headers->EnumerateHeaderLines(&iter, &name, &value))
+ while (response_headers->EnumerateHeaderLines(iter, &name, &value))
headers->Append(helpers::CreateHeaderDictionary(name, value));
}
response_headers_.reset(headers);

Powered by Google App Engine
This is Rietveld 408576698