extensions/browser/api/mime_handler_private/mime_handler_private.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/mime_handler_private/mime_handler_private.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc ('k') | extensions/browser/api/web_request/web_request_api_helpers.cc » ('j') | net/http/http_response_headers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/mime_handler_private/mime_handler_private.cc

diff --git a/extensions/browser/api/mime_handler_private/mime_handler_private.cc b/extensions/browser/api/mime_handler_private/mime_handler_private.cc

index 4a5bb42d6e6d3f85b9992e3f0fae002d741c2dbb..eefd0d86521de2610519eec4237f526ab92ca7b5 100644

--- a/extensions/browser/api/mime_handler_private/mime_handler_private.cc

+++ b/extensions/browser/api/mime_handler_private/mime_handler_private.cc

@@ -24,10 +24,10 @@ mojo::Map<mojo::String, mojo::String> CreateResponseHeadersMap(

if (!headers)

return mojo::Map<mojo::String, mojo::String>::From(result);

- void* iter = nullptr;

+ size_t iter = 0;

std::string header_name;

std::string header_value;

- while (headers->EnumerateHeaderLines(&iter, &header_name, &header_value)) {

+ while (headers->EnumerateHeaderLines(iter, &header_name, &header_value)) {

// mojo strings must be UTF-8 and headers might not be, so drop any headers

// that aren't ASCII. The PDF plugin does not use any headers with non-ASCII

// names and non-ASCII values are never useful for the headers the plugin