extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/shell_devtools_frontend.cc ('k') | extensions/browser/api/mime_handler_private/mime_handler_private.cc » ('j') | net/http/http_response_headers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

index 1e85b1c676668d3a1576e2e5f631a5273f55b289..e88a3797dfff6df97bcb93cc482453047a9e7757 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

@@ -694,8 +694,8 @@ bool WebRequestConditionAttributeResponseHeaders::IsFulfilled(

bool passed = false; // Did some header pass TestNameValue?

std::string name;

std::string value;

- void* iter = NULL;

- while (!passed && headers->EnumerateHeaderLines(&iter, &name, &value)) {

+ size_t iter = 0;

+ while (!passed && headers->EnumerateHeaderLines(iter, &name, &value)) {

passed |= header_matcher_->TestNameValue(name, value);

}