chrome/browser/extensions/api/streams_private/streams_private_api.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_api.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_unittest.cc » ('j') | net/http/http_response_headers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/streams_private/streams_private_api.cc

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.cc b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

index 3f955600ceca503303751d829f59d48beefa34c4..3aa147ee0f22a515b1f1076c95733f9b6f51c365 100644

--- a/chrome/browser/extensions/api/streams_private/streams_private_api.cc

+++ b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

@@ -29,10 +29,10 @@ void CreateResponseHeadersDictionary(const net::HttpResponseHeaders* headers,

if (!headers)

return;

- void* iter = NULL;

+ size_t iter = 0;

std::string header_name;

std::string header_value;

- while (headers->EnumerateHeaderLines(&iter, &header_name, &header_value)) {

+ while (headers->EnumerateHeaderLines(iter, &header_name, &header_value)) {

base::Value* existing_value = NULL;

if (result->Get(header_name, &existing_value)) {

base::StringValue* existing_string_value =