chrome/browser/devtools/devtools_ui_bindings.cc - Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1594973004: Remove use of void** from HttpResponseHeaders::EnumerateHeaderLines (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_contents_io_thread_client_impl.cc ('k') | chrome/browser/extensions/api/streams_private/streams_private_api.cc » ('j') | net/http/http_response_headers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_ui_bindings.cc

diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc

index d86ecd9bb1da4ff7b3427035ef2396a6e6574fe7..e73bf0aafa472be0f7f43fca21cc0040d10c50ae 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.cc

+++ b/chrome/browser/devtools/devtools_ui_bindings.cc

@@ -982,10 +982,10 @@ void DevToolsUIBindings::OnURLFetchComplete(const net::URLFetcher* source) {

response.SetInteger("statusCode", rh ? rh->response_code() : 200);

response.Set("headers", headers);

- void* iterator = NULL;

+ size_t iterator = 0;

std::string name;

std::string value;

- while (rh && rh->EnumerateHeaderLines(&iterator, &name, &value))

+ while (rh && rh->EnumerateHeaderLines(iterator, &name, &value))

headers->SetString(name, value);

it->second.Run(&response);