Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1594443003: [parsing] Move EvalComparison out of the assembler. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-source-position
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parsing] Move EvalComparison out of the assembler. This refactoring removes the dependency on the Token class from the assembler.h header file, the utility function in question has nothing to do with assembling in the first place. R=bmeurer@chromium.org Committed: https://crrev.com/725203d417d0c7b76a6f484ae1b1e7a84e3fb995 Cr-Commit-Position: refs/heads/master@{#33330}

Patch Set 1 #

Patch Set 2 : Drop one more include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M src/assembler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/assembler.cc View 1 2 chunks +0 lines, -18 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/parsing/token.h View 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Michael Starzinger
Benedikt: PTAL at the whole thing. Andreas: Needs "parsing" stamp.
4 years, 11 months ago (2016-01-15 12:15:43 UTC) #2
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-15 12:26:47 UTC) #3
rossberg
lgtm
4 years, 11 months ago (2016-01-15 12:50:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1594443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1594443003/20001
4 years, 11 months ago (2016-01-15 12:51:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 13:14:01 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 13:14:13 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/725203d417d0c7b76a6f484ae1b1e7a84e3fb995
Cr-Commit-Position: refs/heads/master@{#33330}

Powered by Google App Engine
This is Rietveld 408576698