Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1581083009: Move SourcePosition into separate header file. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move SourcePosition into separate header file. This splits out the SourcePosition class into a separate header file. Reason for this refactoring is that said class is mostly used by the Crankshaft compiler and not needed for all compilers. Also having the assembler depend on the class creates a dependency cycle. R=bmeurer@chromium.org Committed: https://crrev.com/0aeaf0cbd1427d063fbf0298590ab8a91e6c7221 Cr-Commit-Position: refs/heads/master@{#33325}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Include what you use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -86 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -63 lines 0 comments Download
M src/compiler.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/crankshaft/lithium-codegen.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +1 line, -1 line 0 comments Download
A src/source-position.h View 1 1 chunk +87 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-15 10:48:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581083009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581083009/1
4 years, 11 months ago (2016-01-15 10:54:49 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 11:38:21 UTC) #5
Benedikt Meurer
LGTM once comment is addressed. https://codereview.chromium.org/1581083009/diff/1/src/source-position.h File src/source-position.h (right): https://codereview.chromium.org/1581083009/diff/1/src/source-position.h#newcode6 src/source-position.h:6: #define V8_SOURCE_POSITION_H_ Can you ...
4 years, 11 months ago (2016-01-15 11:38:49 UTC) #6
Michael Starzinger
https://codereview.chromium.org/1581083009/diff/1/src/source-position.h File src/source-position.h (right): https://codereview.chromium.org/1581083009/diff/1/src/source-position.h#newcode6 src/source-position.h:6: #define V8_SOURCE_POSITION_H_ On 2016/01/15 11:38:49, Benedikt Meurer wrote: > ...
4 years, 11 months ago (2016-01-15 11:46:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581083009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581083009/20001
4 years, 11 months ago (2016-01-15 11:47:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 12:11:41 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 12:11:58 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0aeaf0cbd1427d063fbf0298590ab8a91e6c7221
Cr-Commit-Position: refs/heads/master@{#33325}

Powered by Google App Engine
This is Rietveld 408576698