src/crankshaft/arm/lithium-codegen-arm.cc - Issue 1594443003: [parsing] Move EvalComparison out of the assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/arm/lithium-codegen-arm.cc

Issue 1594443003: [parsing] Move EvalComparison out of the assembler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-source-position

Patch Set: Drop one more include. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/arm/lithium-codegen-arm.cc

diff --git a/src/crankshaft/arm/lithium-codegen-arm.cc b/src/crankshaft/arm/lithium-codegen-arm.cc

index 2bd07882326d9f1b6f7a04eb778752953b7b6ec4..ce0e6733a7926703c82a65a2c5aad7b0e30b1284 100644

--- a/src/crankshaft/arm/lithium-codegen-arm.cc

+++ b/src/crankshaft/arm/lithium-codegen-arm.cc

@@ -2260,8 +2260,9 @@ void LCodeGen::DoCompareNumericAndBranch(LCompareNumericAndBranch* instr) {

// We can statically evaluate the comparison.

double left_val = ToDouble(LConstantOperand::cast(left));

double right_val = ToDouble(LConstantOperand::cast(right));

- int next_block = EvalComparison(instr->op(), left_val, right_val) ?

- instr->TrueDestination(chunk_) : instr->FalseDestination(chunk_);

+ int next_block = Token::EvalComparison(instr->op(), left_val, right_val)

+ ? instr->TrueDestination(chunk_)

+ : instr->FalseDestination(chunk_);

EmitGoto(next_block);

} else {

if (instr->is_double()) {

« no previous file with comments | « src/assembler.cc ('k') | src/crankshaft/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »