Fix GL texture target program key

Fix GL texture target program key
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1593643002

Committed: https://skia.googlesource.com/skia/+/ae04ecf1a3b274e8902948008e999ec2c0af5fba

[bsalomon, 2016-01-15 15:03:20]

Description was changed from

==========
Fix GL texture target program key
==========

to

==========
Fix GL texture target program key
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-15 15:10:50]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[bsalomon, 2016-01-15 15:10:51]

I made the mistake of thinking the per-texture key was a full int, not a short.
Jim had suggested using a similar private static method on GrGLGpu. I tried that
and it felt a little too friendly. In any event we will probably wind up
changing this mechanism slightly to share this code with Vulkan as I believe the
texture target is the only bit of GL-specific code in this file.

[bsalomon, 2016-01-15 15:10:54]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-15 15:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593643002/40001

[commit-bot: I haz the power, 2016-01-15 15:11:03]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-01-15 21:11 UTC

[egdaniel, 2016-01-15 15:40:28]

https://codereview.chromium.org/1593643002/diff/40001/src/gpu/gl/GrGLProgramD...
File src/gpu/gl/GrGLProgramDesc.cpp (right):

https://codereview.chromium.org/1593643002/diff/40001/src/gpu/gl/GrGLProgramD...
src/gpu/gl/GrGLProgramDesc.cpp:46: (texture_target_key(texture->target()) <<
8));
Do we want texture_target_key to return a uint8_t? Obviously now in the current
form this is all safe knowing what texture_target_key returns, but we either
need an assert on the size of the return value or change to uint8 to make sure
we don't lose bits in the future.

[bsalomon, 2016-01-15 16:12:10]

On 2016/01/15 15:40:28, egdaniel wrote:
>
https://codereview.chromium.org/1593643002/diff/40001/src/gpu/gl/GrGLProgramD...
> File src/gpu/gl/GrGLProgramDesc.cpp (right):
> 
>
https://codereview.chromium.org/1593643002/diff/40001/src/gpu/gl/GrGLProgramD...
> src/gpu/gl/GrGLProgramDesc.cpp:46: (texture_target_key(texture->target()) <<
> 8));
> Do we want texture_target_key to return a uint8_t? Obviously now in the
current
> form this is all safe knowing what texture_target_key returns, but we either
> need an assert on the size of the return value or change to uint8 to make sure
> we don't lose bits in the future.

Done

[bsalomon, 2016-01-15 16:12:23]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-15 16:12:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1593643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1593643002/60001

[egdaniel, 2016-01-15 16:16:51]

lgtm

[commit-bot: I haz the power, 2016-01-15 16:25:29]

Description was changed from

==========
Fix GL texture target program key
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix GL texture target program key
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ae04ecf1a3b274e8902948008e999ec2c0af5fba
==========

[commit-bot: I haz the power, 2016-01-15 16:25:29]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/ae04ecf1a3b274e8902948008e999ec2c0af5fba