Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1593313010: Revert of [turbofan] Implement rounding of floats on x64 and ia32 without sse4.1. (Closed)

Created:
4 years, 11 months ago by ahaas
Modified:
4 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Implement rounding of floats on x64 and ia32 without sse4.1. (patchset #2 id:20001 of https://codereview.chromium.org/1584663007/ ) Reason for revert: Code is incorrect for -0. Original issue's description: > [turbofan] Implement rounding of floats on x64 and ia32 without sse4.1. > > The implementation sets the rounding mode flag and then uses the > cvtsd2si and cvtsi2sd instructions (convert between float and int) to do > the rounding. Input values outside int range either don't have to be > rounded anyways, or are rounded by calculating input + 2^52 - 2^52 for > positive inputs, or input -2^52 + 2^52 for negative inputs. The original > rounding mode is restored afterwards. > > R=titzer@chromium.org > > B=575379 > > Committed: https://crrev.com/fa5d09e547abe79a8c82f780deb980c53ad78beb > Cr-Commit-Position: refs/heads/master@{#33367} TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/900b2933480f600bffca650e49b5e581224509bb Cr-Commit-Position: refs/heads/master@{#33369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -770 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +3 lines, -15 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 3 chunks +19 lines, -74 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 3 chunks +19 lines, -33 lines 0 comments Download
M src/ia32/assembler-ia32.h View 3 chunks +0 lines, -7 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 4 chunks +1 line, -41 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +1 line, -32 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -125 lines 0 comments Download
M src/x64/assembler-x64.h View 5 chunks +0 lines, -22 lines 0 comments Download
M src/x64/assembler-x64.cc View 3 chunks +129 lines, -178 lines 0 comments Download
M src/x64/disasm-x64.cc View 3 chunks +0 lines, -34 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +0 lines, -134 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 1 chunk +43 lines, -30 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 3 chunks +5 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ahaas
Created Revert of [turbofan] Implement rounding of floats on x64 and ia32 without sse4.1.
4 years, 11 months ago (2016-01-18 16:26:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1593313010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1593313010/1
4 years, 11 months ago (2016-01-18 16:26:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 16:26:59 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 16:28:08 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/900b2933480f600bffca650e49b5e581224509bb
Cr-Commit-Position: refs/heads/master@{#33369}

Powered by Google App Engine
This is Rietveld 408576698