Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 1593313010: Revert of [turbofan] Implement rounding of floats on x64 and ia32 without sse4.1. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ia32/instruction-selector-ia32.cc
diff --git a/src/compiler/ia32/instruction-selector-ia32.cc b/src/compiler/ia32/instruction-selector-ia32.cc
index f5af219f5984d42674644f7828a67c20872f627a..fa21d52d1565d6d377cfeebc7c4cefbdd6906676 100644
--- a/src/compiler/ia32/instruction-selector-ia32.cc
+++ b/src/compiler/ia32/instruction-selector-ia32.cc
@@ -871,74 +871,32 @@
void InstructionSelector::VisitFloat32RoundDown(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundDown));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat32Round | MiscField::encode(kRoundDown),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundDown));
}
void InstructionSelector::VisitFloat64RoundDown(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundDown));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat64Round | MiscField::encode(kRoundDown),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundDown));
}
void InstructionSelector::VisitFloat32RoundUp(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundUp));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat32Round | MiscField::encode(kRoundUp),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundUp));
}
void InstructionSelector::VisitFloat64RoundUp(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundUp));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat64Round | MiscField::encode(kRoundUp),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundUp));
}
void InstructionSelector::VisitFloat32RoundTruncate(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundToZero));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat32Round | MiscField::encode(kRoundToZero),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundToZero));
}
void InstructionSelector::VisitFloat64RoundTruncate(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundToZero));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat64Round | MiscField::encode(kRoundToZero),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundToZero));
}
@@ -948,26 +906,12 @@
void InstructionSelector::VisitFloat32RoundTiesEven(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundToNearest));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat32Round | MiscField::encode(kRoundToNearest),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat32Round | MiscField::encode(kRoundToNearest));
}
void InstructionSelector::VisitFloat64RoundTiesEven(Node* node) {
- if (CpuFeatures::IsSupported(SSE4_1)) {
- VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundToNearest));
- } else {
- IA32OperandGenerator g(this);
- InstructionOperand temps[] = {g.TempRegister()};
- Emit(kSSEFloat64Round | MiscField::encode(kRoundToNearest),
- g.DefineSameAsFirst(node), g.UseRegister(node->InputAt(0)), 1, temps);
- }
+ VisitRR(this, node, kSSEFloat64Round | MiscField::encode(kRoundToNearest));
}
@@ -1379,18 +1323,19 @@
MachineOperatorBuilder::kFloat64Max |
MachineOperatorBuilder::kFloat64Min |
MachineOperatorBuilder::kWord32ShiftIsSafe |
- MachineOperatorBuilder::kWord32Ctz |
- MachineOperatorBuilder::kFloat32RoundDown |
- MachineOperatorBuilder::kFloat32RoundUp |
- MachineOperatorBuilder::kFloat32RoundTruncate |
- MachineOperatorBuilder::kFloat32RoundTiesEven |
- MachineOperatorBuilder::kFloat64RoundDown |
- MachineOperatorBuilder::kFloat64RoundUp |
- MachineOperatorBuilder::kFloat64RoundTruncate |
- MachineOperatorBuilder::kFloat64RoundTiesEven;
-
+ MachineOperatorBuilder::kWord32Ctz;
if (CpuFeatures::IsSupported(POPCNT)) {
flags |= MachineOperatorBuilder::kWord32Popcnt;
+ }
+ if (CpuFeatures::IsSupported(SSE4_1)) {
+ flags |= MachineOperatorBuilder::kFloat32RoundDown |
+ MachineOperatorBuilder::kFloat64RoundDown |
+ MachineOperatorBuilder::kFloat32RoundUp |
+ MachineOperatorBuilder::kFloat64RoundUp |
+ MachineOperatorBuilder::kFloat32RoundTruncate |
+ MachineOperatorBuilder::kFloat64RoundTruncate |
+ MachineOperatorBuilder::kFloat32RoundTiesEven |
+ MachineOperatorBuilder::kFloat64RoundTiesEven;
}
return flags;
}
« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698