Clean up dead code after spread desugaring

Clean up dead code after spread desugaring

After 1564083002, spread expressions are desugared and should not
survive in the AST after parsing. This patch removes dead code
related to this.  It also eliminates the kSpread bailout reason
and the concat_iterable_to_array_builtin.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/722909f38ead4e6d2d182a66ab668a93ceb0e6a4
Cr-Commit-Position: refs/heads/master@{#33385}

[Benedikt Meurer, 2016-01-15 10:32:34]

As per offline discussion: We should be able to drop CONCAT_ITERABLE_TO_ARRAY
completely now.

[nickie, 2016-01-18 10:22:57]

On 2016/01/15 10:32:34, Benedikt Meurer wrote:
> As per offline discussion: We should be able to drop CONCAT_ITERABLE_TO_ARRAY
> completely now.

This concerns CONCAT_ITERABLE_TO_ARRAY_BUILTIN, I suppose.
CONCAT_ITERABLE_TO_ARRAY is still used in the pattern rewriter for destructuring
assignment.

[Benedikt Meurer, 2016-01-18 11:30:31]

Ok. LGTM.

[nickie, 2016-01-18 11:34:45]

https://codereview.chromium.org/1592713002/diff/1/src/ast/ast-literal-reindex...
File src/ast/ast-literal-reindexer.cc (right):

https://codereview.chromium.org/1592713002/diff/1/src/ast/ast-literal-reindex...
src/ast/ast-literal-reindexer.cc:196: #else
Andreas, does this stay?

[nickie, 2016-01-18 14:25:39]

https://codereview.chromium.org/1592713002/diff/1/src/ast/ast-literal-reindex...
File src/ast/ast-literal-reindexer.cc (right):

https://codereview.chromium.org/1592713002/diff/1/src/ast/ast-literal-reindex...
src/ast/ast-literal-reindexer.cc:196: #else
On 2016/01/18 11:34:45, nickie wrote:
> Andreas, does this stay?

We decided the first two lines of the comment stay.

[nickie, 2016-01-18 14:39:49]

Patchset #2 (id:20001) has been deleted

[nickie, 2016-01-18 15:19:20]

On 2016/01/18 11:30:31, Benedikt Meurer wrote:
> Ok. LGTM.

PTAL

[nickie, 2016-01-19 09:30:54]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-01-19 09:30:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1592713002/#ps60001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-01-19 09:31:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592713002/60001

[commit-bot: I haz the power, 2016-01-19 09:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 09:32:06]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/205)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/202)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/14250)

[nickie, 2016-01-19 09:45:37]

Description was changed from

==========
Clean up dead code after spread desugaring

After 1564083002, spread expressions are desugared and should not
survive in the AST after parsing. This patch removes dead code
related to this.  It also eliminates the kSpread bailout reason.

R=bmeurer@chromium.org
BUG=
==========

to

==========
Clean up dead code after spread desugaring

After 1564083002, spread expressions are desugared and should not
survive in the AST after parsing. This patch removes dead code
related to this.  It also eliminates the kSpread bailout reason
and the concat_iterable_to_array_builtin.

R=bmeurer@chromium.org
BUG=
==========

[nickie, 2016-01-19 10:10:03]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-01-19 10:10:03]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1592713002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-19 10:10:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592713002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592713002/80001

[commit-bot: I haz the power, 2016-01-19 10:26:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 10:26:07]

Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12548)

[nickie, 2016-01-19 11:40:13]

The CQ bit was checked by nikolaos@chromium.org

[nickie, 2016-01-19 11:40:14]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1592713002/#ps100001
(title: "Fix bug that visited dead AST node in for/of")

[commit-bot: I haz the power, 2016-01-19 11:40:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1592713002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1592713002/100001

[commit-bot: I haz the power, 2016-01-19 12:05:41]

Description was changed from

==========
Clean up dead code after spread desugaring

After 1564083002, spread expressions are desugared and should not
survive in the AST after parsing. This patch removes dead code
related to this.  It also eliminates the kSpread bailout reason
and the concat_iterable_to_array_builtin.

R=bmeurer@chromium.org
BUG=
==========

to

==========
Clean up dead code after spread desugaring

After 1564083002, spread expressions are desugared and should not
survive in the AST after parsing. This patch removes dead code
related to this.  It also eliminates the kSpread bailout reason
and the concat_iterable_to_array_builtin.

R=bmeurer@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-01-19 12:05:42]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-01-19 12:06:36]

Description was changed from

==========
Clean up dead code after spread desugaring

After 1564083002, spread expressions are desugared and should not
survive in the AST after parsing. This patch removes dead code
related to this.  It also eliminates the kSpread bailout reason
and the concat_iterable_to_array_builtin.

R=bmeurer@chromium.org
BUG=
==========

to

==========
Clean up dead code after spread desugaring

After 1564083002, spread expressions are desugared and should not
survive in the AST after parsing. This patch removes dead code
related to this.  It also eliminates the kSpread bailout reason
and the concat_iterable_to_array_builtin.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/722909f38ead4e6d2d182a66ab668a93ceb0e6a4
Cr-Commit-Position: refs/heads/master@{#33385}
==========

[commit-bot: I haz the power, 2016-01-19 12:06:37]

Patchset 5 (id:??) landed as
https://crrev.com/722909f38ead4e6d2d182a66ab668a93ceb0e6a4
Cr-Commit-Position: refs/heads/master@{#33385}