Clean up dead code after spread desugaring

src/ast/ast-literal-reindexer.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ast/ast-literal-reindexer.h"
 
 #include "src/ast/ast.h"
 #include "src/ast/scopes.h"
 
 namespace v8 {
@@ skipping 169 matching lines @@
 }
 
 
 void AstLiteralReindexer::VisitCompareOperation(CompareOperation* node) {
   Visit(node->left());
   Visit(node->right());
 }
 
 
 void AstLiteralReindexer::VisitSpread(Spread* node) {
+#if 0
+  // This is reachable because ParserBase::ParseArrowFunctionLiteral calls
+  // ReindexLiterals before calling RewriteDestructuringAssignments.
+  // Breaking test case: var f = ([...a]) => {}
+  // TODO(rossberg): Add a proper TODO here as to what needs to be done.
+  UNREACHABLE();
+#else

[nickie, 2016/01/18 11:34:45]

Andreas, does this stay?

[nickie, 2016/01/18 14:25:39]

We decided the first two lines of the comment stay.

   Visit(node->expression());
+#endif
 }
 
 
 void AstLiteralReindexer::VisitEmptyParentheses(EmptyParentheses* node) {}
 
 
 void AstLiteralReindexer::VisitForInStatement(ForInStatement* node) {
   Visit(node->each());
   Visit(node->enumerable());
   Visit(node->body());
@@ skipping 121 matching lines @@
 void AstLiteralReindexer::VisitFunctionLiteral(FunctionLiteral* node) {
   // We don't recurse into the declarations or body of the function literal:
 }
 
 
 void AstLiteralReindexer::Reindex(Expression* pattern) {
   pattern->Accept(this);
 }
 }  // namespace internal
 }  // namespace v8