src/ast/ast-literal-reindexer.cc - Issue 1592713002: Clean up dead code after spread desugaring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast-literal-reindexer.cc

Issue 1592713002: Clean up dead code after spread desugaring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix bug that visited dead AST node in for/of Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast-literal-reindexer.cc

diff --git a/src/ast/ast-literal-reindexer.cc b/src/ast/ast-literal-reindexer.cc

index 6db9a61b9b48e235b3d06020b39aae448b93dde9..5af5e412a07b2de64715bd79370fcc2ec1626a9f 100644

--- a/src/ast/ast-literal-reindexer.cc

+++ b/src/ast/ast-literal-reindexer.cc

@@ -188,6 +188,8 @@ void AstLiteralReindexer::VisitCompareOperation(CompareOperation* node) {

void AstLiteralReindexer::VisitSpread(Spread* node) {

+ // This is reachable because ParserBase::ParseArrowFunctionLiteral calls

+ // ReindexLiterals before calling RewriteDestructuringAssignments.

Visit(node->expression());

}

« no previous file with comments | « src/ast/ast.cc ('k') | src/ast/ast-numbering.cc » ('j') | no next file with comments »