Subzero. ARM32. Fixes vpush/vpop bug.

Subzero. ARM32. Fixes vpush/vpop bug.

if vpush/vpop needs to emit multiple instructions (because of
non-consecutive registers), then the emitted sequence should be:

vpush list1
vpush list2
...
vpop list2
vpop list1

Subzero was emiting vpop in the wrong order:

vpop list1
vpop list2

These multiple lists push/pop arise because of the way fp32 and fp64
registers are declared (s0 -> s31, d31 -> d0).

This CL modifies fp64 registers so they are declared in ascending
order (d0 -> d31), which fixes subzero temporarily. The appropriate
fix is to change vpop to be emitted in the right order.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
R=sehr@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b819665aac0c747bd2337eb72f91f4b1de11f688

[John, 2016-01-15 23:34:06]

jpp@chromium.org changed reviewers:
+ kschimpf@google.com, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-01-15 23:35:57]

lgtm

[sehr, 2016-01-16 05:25:36]

lgtm

[John, 2016-01-19 14:19:17]

Description was changed from

==========
Subzero. ARM32. Fixes vpush/vpop bug.

if vpush/vpop needs to emit multiple instructions (because of
non-consecutive registers), then the emitted sequence should be:

vpush list1
vpush list2
...
vpop list2
vpop list1

Subzero was emiting vpop in the wrong order:

vpop list1
vpop list2

These multiple lists push/pop arise because of the way fp32 and fp64
registers are declared (s0 -> s31, d31 -> d0).

This CL modifies fp64 registers so they are declared in ascending
order (d0 -> d31), which fixes subzero temporarily. The appropriate
fix is to change vpop to be emitted in the right order.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
==========

to

==========
Subzero. ARM32. Fixes vpush/vpop bug.

if vpush/vpop needs to emit multiple instructions (because of
non-consecutive registers), then the emitted sequence should be:

vpush list1
vpush list2
...
vpop list2
vpop list1

Subzero was emiting vpop in the wrong order:

vpop list1
vpop list2

These multiple lists push/pop arise because of the way fp32 and fp64
registers are declared (s0 -> s31, d31 -> d0).

This CL modifies fp64 registers so they are declared in ascending
order (d0 -> d31), which fixes subzero temporarily. The appropriate
fix is to change vpop to be emitted in the right order.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076
R=sehr@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2016-01-19 14:19:18]

Committed patchset #2 (id:20001) manually as
b819665aac0c747bd2337eb72f91f4b1de11f688 (presubmit successful).