pydir/gen_arm32_reg_tables.py - Issue 1592663004: Subzero. ARM32. Fixes vpush/vpop bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/gen_arm32_reg_tables.py

Issue 1592663004: Subzero. ARM32. Fixes vpush/vpop bug. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/gen_arm32_reg_tables.py

diff --git a/pydir/gen_arm32_reg_tables.py b/pydir/gen_arm32_reg_tables.py

index 749a119cc3d1884da1fc78ea6192aea90600ee9f..d2058ab84f1d47d4599b38c4a1385eb2561e6e4b 100644

--- a/pydir/gen_arm32_reg_tables.py

+++ b/pydir/gen_arm32_reg_tables.py

@@ -194,11 +194,9 @@ Vec128 = [

Reg('q15', 15, IsScratch=1, IsVec128=1, Aliases='q15, d30, d31'),

]

-def _reverse(x):

- return sorted(x, key=lambda x: x.Encode, reverse=True)

-RegClasses = [('GPR', GPRs), ('I64PAIR', I64Pairs), ('FP32', FP32),

- ('FP64', _reverse(FP64)), ('VEC128', _reverse(Vec128))]

+# TODO(jpp): Fix the pop emission, then emit FP64/Vec128 reverted.

+RegClasses = [('GPR', GPRs), ('I64PAIR', I64Pairs), ('FP32', FP32),

+ ('FP64', FP64), ('VEC128', Vec128)]

AllRegs = {}

for _, RegClass in RegClasses:

« no previous file with comments | « Makefile.standalone ('k') | src/IceRegistersARM32.def » ('j') | no next file with comments »