Issue 159196: Don't kill dsymutil after it finishes....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159196: Don't kill dsymutil after it finishes.... (Closed)

Created:
11 years, 5 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, stuartmorgan, dank, the_wrong_timurrrr, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't kill dsymutil after it finishes. BUG=17441 TEST=sh tools/valgrind/chrome_test.sh -t ui on mac, watch it not time out when running dsymutil Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21361

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	tools/valgrind/valgrind_test.py	View		1 chunk	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

11 years, 5 months ago (2009-07-22 15:34:32 UTC) #2

LGTM.

It's the workaround I'm going to use tonight, yes.

http://codereview.chromium.org/159196/diff/1/2
File tools/valgrind/valgrind_test.py (right):

http://codereview.chromium.org/159196/diff/1/2#newcode192
Line 192: common.RunSubprocess(dsymutil_command, 0)
Uber-nit: I'd either leave out the ', 0' (it's the default) or put a '# 0 means
no timeout' somewhere.

Expand Messages | Collapse Messages