Don't kill dsymutil after it finishes....

tools/valgrind/valgrind_test.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # valgrind_test.py
 
 '''Runs an exe through Valgrind and puts the intermediate files in a
 directory.
 '''
@@ skipping 167 matching lines @@
         shutil.copyfile(dsym_file, test_command)
         shutil.copymode(saved_test_command, test_command)
 
     if needs_dsymutil:
       if self._options.generate_dsym:
         # Remove the .dSYM bundle if it exists.
         shutil.rmtree(dsym_bundle, True)
 
         dsymutil_command = ['dsymutil', test_command]
 
-        # dsymutil is crazy slow.  Let it run for up to a half hour.  I hope
-        # that's enough.
-        common.RunSubprocess(dsymutil_command, 30 * 60)
+        # dsymutil is crazy slow.  Ideally we'd have a timeout here,
+        # but common.RunSubprocess' timeout is only checked
+        # after each line of output; dsymutil is silent
+        # until the end, and is then killed, which is silly.
+        common.RunSubprocess(dsymutil_command, 0)

[Nico, 2009/07/22 15:34:32]

Uber-nit: I'd either leave out the ', 0' (it's the default) or put a '# 0 means
no timeout' somewhere.

 
         if saved_test_command:
           os.rename(saved_test_command, test_command)
       else:
         logging.info("No real .dSYM for test_command.  Line numbers will "
                      "not be shown.  Either tell xcode to generate .dSYM "
                      "file, or use --generate_dsym option to this tool.")
 
   def ValgrindCommand(self):
     """Get the valgrind command to run."""
@@ skipping 251 matching lines @@
 
 if __name__ == "__main__":
   if sys.argv.count("-v") > 0 or sys.argv.count("--verbose") > 0:
     google.logging_utils.config_root(logging.DEBUG)
   else:
     google.logging_utils.config_root()
   # TODO(timurrrr): valgrind tools may use -v/--verbose as well
 
   ret = RunTool(sys.argv)
   sys.exit(ret)