Don't kill dsymutil after it finishes....

tools/valgrind/valgrind_test.py

Index: tools/valgrind/valgrind_test.py
===================================================================
--- tools/valgrind/valgrind_test.py	(revision 21235)
+++ tools/valgrind/valgrind_test.py	(working copy)
@@ -185,9 +185,11 @@
 
         dsymutil_command = ['dsymutil', test_command]
 
-        # dsymutil is crazy slow.  Let it run for up to a half hour.  I hope
-        # that's enough.
-        common.RunSubprocess(dsymutil_command, 30 * 60)
+        # dsymutil is crazy slow.  Ideally we'd have a timeout here,
+        # but common.RunSubprocess' timeout is only checked
+        # after each line of output; dsymutil is silent
+        # until the end, and is then killed, which is silly.
+        common.RunSubprocess(dsymutil_command, 0)

[Nico, 2009/07/22 15:34:32]

Uber-nit: I'd either leave out the ', 0' (it's the default) or put a '# 0 means
no timeout' somewhere.

 
         if saved_test_command:
           os.rename(saved_test_command, test_command)