Fix Views new dialog style hit-testing.

Fix Views new dialog style hit-testing.

This CL is a continuation of a reverted CL:
https://codereview.chromium.org/16084008/
This CL fixes test failures/crashes that caused revert.
It also refines the behavior and improves testing.

Allow non-resizable dialog dragging (and system menu).
(revise NonClientHitTest to return HTCAPTION as needed)
This was a regression from my http://crrev.com/202000

Allow the top-left to show the system menu on left-click.
Allow dragging dialogs from the frame view side/bottom.
This is new behavior that I think is good :)

Expand BubbleFrameViewTest.NonClientHitTest and support.
Add dialog_delegate_unittest.cc and DialogTest.HitTest.

BUG=244676, 166075
TEST=all non-constrained dialogs can be dragged, and their Windows system menus are shown on title-bar right-click, and top-left area left-click.
R=sky@chromium.org

ABANDONED DUE TO INTENDED BEHAVIOR CHANGE.

[msw, 2013-06-04 01:19:59]

Hey Scott, please take a look at this updated CL; thanks!

[sky, 2013-06-04 14:51:09]

LGTM

[commit-bot: I haz the power, 2013-06-04 16:47:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/15894025/9003

[msw, 2013-06-04 18:09:04]

I was just notified of a change to the intended behavior by Glen.
1) New-style dialogs may not be resized at all.
2) Only top-level dialogs may be dragged.
3) Parented dialogs should be positioned like web contents modal dialogs.
I'll abandon this issue and address these changes in another CL.

[sky, 2013-06-04 21:06:47]

You likely also need to make it so that if the parent is dragged the
dialog also moves.

On Tue, Jun 4, 2013 at 11:09 AM,  <msw@chromium.org> wrote:
> I was just notified of a change to the intended behavior by Glen.
> 1) New-style dialogs may not be resized at all.
> 2) Only top-level dialogs may be dragged.
> 3) Parented dialogs should be positioned like web contents modal dialogs.
> I'll abandon this issue and address these changes in another CL.
>
> https://codereview.chromium.org/15894025/

[msw, 2013-06-04 21:23:20]

On 2013/06/04 21:06:47, sky wrote:
> You likely also need to make it so that if the parent is dragged the
> dialog also moves.

The parent window is made non-interactive for child dialogs.
I'm not sure what we'll do here, see http://crbug.com/246777

[sky, 2013-06-04 22:58:05]

What about things like calendar alerts? Those doesn't change the parent.

On Tue, Jun 4, 2013 at 2:23 PM,  <msw@chromium.org> wrote:
> On 2013/06/04 21:06:47, sky wrote:
>>
>> You likely also need to make it so that if the parent is dragged the
>> dialog also moves.
>
>
> The parent window is made non-interactive for child dialogs.
> I'm not sure what we'll do here, see http://crbug.com/246777
>
> https://codereview.chromium.org/15894025/

[msw, 2013-06-04 23:05:23]

On 2013/06/04 22:58:05, sky wrote:
> What about things like calendar alerts? Those doesn't change the parent.

JavaScript alerts make their parent non-interactive regradless of style.
There is no behavior change there, but eventually we should re-evaluate.
Modality should be somewhat disjoint from parenting.

[sky, 2013-06-04 23:20:34]

Good point.

On Tue, Jun 4, 2013 at 4:05 PM,  <msw@chromium.org> wrote:
> On 2013/06/04 22:58:05, sky wrote:
>>
>> What about things like calendar alerts? Those doesn't change the parent.
>
>
> JavaScript alerts make their parent non-interactive regradless of style.
> There is no behavior change there, but eventually we should re-evaluate.
> Modality should be somewhat disjoint from parenting.
>
> https://codereview.chromium.org/15894025/

[mtomasz, 2013-06-19 06:49:18]

On 2013/06/04 23:20:34, sky wrote:
> Good point.
> 
> On Tue, Jun 4, 2013 at 4:05 PM,  <mailto:msw@chromium.org> wrote:
> > On 2013/06/04 22:58:05, sky wrote:
> >>
> >> What about things like calendar alerts? Those doesn't change the parent.
> >
> >
> > JavaScript alerts make their parent non-interactive regradless of style.
> > There is no behavior change there, but eventually we should re-evaluate.
> > Modality should be somewhat disjoint from parenting.
> >
> > https://codereview.chromium.org/15894025/

I'm very surprised that resizing got disabled. I think we want the save-as and
open dialog to be resizeable.
There is a lot of content inside.

[msw, 2013-06-19 07:41:13]

On 2013/06/19 06:49:18, mtomasz wrote:
> On 2013/06/04 23:20:34, sky wrote:
> > Good point.
> > 
> > On Tue, Jun 4, 2013 at 4:05 PM,  <mailto:msw@chromium.org> wrote:
> > > On 2013/06/04 22:58:05, sky wrote:
> > >>
> > >> What about things like calendar alerts? Those doesn't change the parent.
> > >
> > >
> > > JavaScript alerts make their parent non-interactive regradless of style.
> > > There is no behavior change there, but eventually we should re-evaluate.
> > > Modality should be somewhat disjoint from parenting.
> > >
> > > https://codereview.chromium.org/15894025/
> 
> I'm very surprised that resizing got disabled. I think we want the save-as and
> open dialog to be resizeable.
> There is a lot of content inside.

It was a PM/UX/leads decision; see http://crrev.com/204190 and its bugs.
You can talk with Ben, Glen, Andrew, and others; I was also confused.