Chromium Code Reviews Chromium Code Reviews
Issue
16084008:
Restore Views dialog dragging and titlebar system menus. (Closed)
DescriptionRestore Views dialog dragging and titlebar system menus.
Allow non-resizable dialog dragging (and system menu).
(revise NonClientHitTest to return HTCAPTION as needed)
This was a regression from my http://crrev.com/202000
Allow dragging dialogs from the frame view side/botttom.
This is new behavior that I think is good :)
Expand BubbleFrameViewTest.NonClientHitTest and support.
Pass through BubbleBorderDelegate's CanResize logic.
(really just needed temporarily for the added unit testing)
BUG=244676, 166075
TEST=all non-constrained dialogs can be dragged, and their Windows system menus are shown on title-bar right click.
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203354
Patch Set 1 #Patch Set 2 : Expand resize and move areas; refactor. #Patch Set 3 : Expand unit test; fix BubbleBorderDelegate pass-through; etc. #Patch Set 4 : Restore the test anchor view, its parent widget is needed on Aura. #Patch Set 5 : Limit the HTCAPTION return value to dialogs. #Patch Set 6 : Add a TestBubbleDelegateView hack for hit testing. #
Messages
Total messages: 12 (0 generated)
|
|||||||||||||||||||||||||||||||||||||
