Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1589243002: Don't use chrome_apk_version_code in remoting_apk. (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Yaron, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remoting
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use chrome_apk_version_code in remoting_apk. chrome_apk_version_code is for chrome_apk. There are now global args for setting the default version code & name for targets that don't want to create their own: - android_default_version_name - android_default_version_code BUG=none Committed: https://crrev.com/b89a4766271a8306c255fd70864650683b54e4a6 Cr-Commit-Position: refs/heads/master@{#369782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
D chrome/android/chrome_apk_version.gni View 1 chunk +0 lines, -8 lines 0 comments Download
M remoting/android/remoting_apk_tmpl.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
agrieve
◢ ◣ ◥ ◤
4 years, 11 months ago (2016-01-15 01:55:36 UTC) #2
Yaron
lgtm
4 years, 11 months ago (2016-01-15 16:01:58 UTC) #3
joedow
lgtm
4 years, 11 months ago (2016-01-15 16:03:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589243002/1
4 years, 11 months ago (2016-01-15 16:49:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 17:42:17 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 17:43:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b89a4766271a8306c255fd70864650683b54e4a6
Cr-Commit-Position: refs/heads/master@{#369782}

Powered by Google App Engine
This is Rietveld 408576698