Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 1582423003: Fix remoting_apk compile when is_component_build = true (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
pkotwicz, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remoting-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix remoting_apk compile when is_component_build = true Verified that tests pass. BUG=577961 Committed: https://crrev.com/50ad1bb89bf7a4ab1435820d7b72c2466dccc6a6 Cr-Commit-Position: refs/heads/master@{#369834}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M remoting/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/android/remoting_apk_tmpl.gni View 1 chunk +12 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
agrieve
ptal
4 years, 11 months ago (2016-01-15 02:12:15 UTC) #3
joedow
lgtm
4 years, 11 months ago (2016-01-15 16:04:08 UTC) #4
pkotwicz
LGTM. I tried the tests locally with the component build and the tests passed
4 years, 11 months ago (2016-01-15 16:27:35 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1589243002 Patch 1). Please resolve the dependency and ...
4 years, 11 months ago (2016-01-15 16:49:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582423003/20001
4 years, 11 months ago (2016-01-15 20:05:11 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 20:39:26 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 20:40:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50ad1bb89bf7a4ab1435820d7b72c2466dccc6a6
Cr-Commit-Position: refs/heads/master@{#369834}

Powered by Google App Engine
This is Rietveld 408576698