Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1573913010: GN: Fix remoting_test_apk compile when is_chrome_branded=true (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Lambros, garykac, Jamie, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix remoting_test_apk compile when is_chrome_branded=true Without this, we were getting: Exception: Wrong instrumented package. Expected com.google.chromeremotedesktop, got org.chromium.chromoting BUG=577483 Committed: https://crrev.com/8d9760336fca653d8fbaa626a6d83142e87af726 Cr-Commit-Position: refs/heads/master@{#369647}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -26 lines) Patch
M remoting/android/BUILD.gn View 1 chunk +11 lines, -1 line 0 comments Download
D remoting/android/javatests/AndroidManifest.xml View 1 chunk +0 lines, -22 lines 0 comments Download
A + remoting/android/javatests/AndroidManifest.xml.jinja2 View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/remoting_android.gypi View 1 chunk +27 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
agrieve
Added multiple reviewers since hoping for short turn-around (official android builder broken at the moment)
4 years, 11 months ago (2016-01-14 21:20:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573913010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573913010/20001
4 years, 11 months ago (2016-01-14 21:28:01 UTC) #5
joedow
lgtm
4 years, 11 months ago (2016-01-14 21:41:34 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 22:05:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1573913010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1573913010/20001
4 years, 11 months ago (2016-01-15 01:21:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 01:27:34 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 01:28:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d9760336fca653d8fbaa626a6d83142e87af726
Cr-Commit-Position: refs/heads/master@{#369647}

Powered by Google App Engine
This is Rietveld 408576698