Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

texSubImage3D currently supports various image sources except ImageBitmap,
this CL adds its support for ImageBitmap.

BUG=577707
Committed: https://crrev.com/46fd74602f2a4c1c3217246b1534d2857c851ef6
Cr-Commit-Position: refs/heads/master@{#369797}

[xidachen, 2016-01-15 03:22:17]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org, kbr@chromium.org

[xidachen, 2016-01-15 03:22:18]

PTAL.

[Ken Russell (switch to Gerrit), 2016-01-15 03:41:55]

LGTM. I assume tests are coming. One comment.

https://codereview.chromium.org/1589003003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
(right):

https://codereview.chromium.org/1589003003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl:329:
[RaisesException] void texSubImage3D(GLenum target, GLint level, GLint xoffset,
GLint yoffset, GLint zoffset, GLenum format, GLenum type, ImageBitmap? bitmap);
The CL description says this should be behind the experimental canvas feature
flag, but it's missing the extended attribute. Which is correct?

[xidachen, 2016-01-15 14:44:08]

Description was changed from

==========
Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

texSubImage3D currently supports various image sources except ImageBitmap,
this CL adds its support for ImageBitmap. Also, this method should be
hiding behind the experimental canvas feature flag at this moment.

BUG=577707
==========

to

==========
Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

texSubImage3D currently supports various image sources except ImageBitmap,
this CL adds its support for ImageBitmap.

BUG=577707
==========

[xidachen, 2016-01-15 14:47:27]

I forgot to update the description when I submit PS#2.

So in PS#1, I did make this method hiding behind a runtime flag, but I found
that the entire WebGL2RenderingContextBase is hiding behind the
RuntimeEnabled=UnsafeES3APIs flag, and apparently having two runtime flag in the
same .idl cause compile error. I filed a bug here:
https://code.google.com/p/chromium/issues/detail?id=577979

I think it is okay to not use the runtime flag here. Because currently
createImageBitmap is still hiding behind the flag, which means that without
using the runtime flag, the texSubImage3D(ImageBitmap) can never be called. Once
ImageBitmap is shipped, the runtime flag for createImageBitmap will be removed,
and then texSubImage3D will be exposed too.

[xidachen, 2016-01-15 17:46:45]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-01-15 17:47:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1589003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1589003003/20001

[Justin Novosad, 2016-01-15 18:02:20]

nice.

[xidachen, 2016-01-15 18:03:28]

On 2016/01/15 18:02:20, Justin Novosad wrote:
> nice.

BTW, conformance test is coming right after this.

[commit-bot: I haz the power, 2016-01-15 18:59:36]

Description was changed from

==========
Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

texSubImage3D currently supports various image sources except ImageBitmap,
this CL adds its support for ImageBitmap.

BUG=577707
==========

to

==========
Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

texSubImage3D currently supports various image sources except ImageBitmap,
this CL adds its support for ImageBitmap.

BUG=577707
==========

[commit-bot: I haz the power, 2016-01-15 18:59:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-15 19:00:32]

Description was changed from

==========
Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

texSubImage3D currently supports various image sources except ImageBitmap,
this CL adds its support for ImageBitmap.

BUG=577707
==========

to

==========
Support ImageBitmap in WebGL2RenderingContextBase::texSubImage3D

texSubImage3D currently supports various image sources except ImageBitmap,
this CL adds its support for ImageBitmap.

BUG=577707

Committed: https://crrev.com/46fd74602f2a4c1c3217246b1534d2857c851ef6
Cr-Commit-Position: refs/heads/master@{#369797}
==========

[commit-bot: I haz the power, 2016-01-15 19:00:33]

Patchset 2 (id:??) landed as
https://crrev.com/46fd74602f2a4c1c3217246b1534d2857c851ef6
Cr-Commit-Position: refs/heads/master@{#369797}