scripts/slave/recipes/android/perf.py - Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/perf.py

Issue 1588793002: Support variable substitution and tryserver- and waterfall-only cmd line args. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressed review feedback. Revised tests. Rebased. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/android/perf.py

diff --git a/scripts/slave/recipes/android/perf.py b/scripts/slave/recipes/android/perf.py

index d71238673789907c049230c33fccefba5805c640..dba47baef1fab3709a8e43a7339162436ed7a885 100644

--- a/scripts/slave/recipes/android/perf.py

+++ b/scripts/slave/recipes/android/perf.py

@@ -140,7 +140,7 @@ def RunSteps(api):

dep = builder.get('set_component_rev')

api.gclient.c.revisions[dep['name']] = dep['rev_str'] % component_rev

- api.bot_update.ensure_checkout()

+ bot_update_step = api.bot_update.ensure_checkout()

test_spec_file = builder.get('test_spec_file')

test_spec = {}

@@ -152,7 +152,8 @@ def RunSteps(api):

builder['tests'] = api.chromium_tests.generate_tests_from_test_spec(

api, test_spec, builder, buildername, mastername, False,

- scripts_compile_targets, [api.chromium_tests.steps.generate_script])

+ scripts_compile_targets, [api.chromium_tests.steps.generate_script],

+ bot_update_step)

api.path['checkout'] = api.path['slave_build'].join('src')

api.chromium_android.clean_local_files()

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/steps.py ('k') | scripts/slave/recipes/chromium.py » ('j') | no next file with comments »